[CLI] Add --wordpress-install-mode flag #2803
Conversation
adamziel
added
[Type] Enhancement
## Motivation for the change, related issues Part of #2202 Add Japanese translations to JavaScript API
## Motivation for the change, related issues Importing WXR content with URL rewriting enabled replaces the protocol in some URLs from `https` to `http`. ## Implementation details Sets `$_SERVER['HTTPS'] = "on"` in the `importWxr` Blueprint step. The `php.run()` method called in the `importWxr` step does not set it automatically – that's a role of the request handler. The WXR importer relies on the `get_site_url()` WordPress function, which weirdly takes the `site_url` option and replaces the protocol based on the `$_SERVER['https']` value. ## Testing Instructions (or ideally a Blueprint) Import this WXR file via `?importWxr` query parameter and confirm all the URLs are https: https://gist.github.com/adamziel/a3d1a1941608e068e4b3d557ee2e8202/raw/aa659a130e1104cedeea8a63155a117dcb693dc8/tt25export.xml The tricky part is, you need to serve Playground on a https url for this to work. cc @bph
There was a problem hiding this comment.
There are some failing tests, but this reads well to me. Thank you, @adamziel!
packages/docs/site/docs/developers/05-local-development/04-wp-playground-cli.md
Show resolved
Hide resolved
| * just as the web request layer would. | ||
| */ | ||
| HTTPS: (await playground.absoluteUrl).startsWith('https://') ? 'on' : '', | ||
| }, |
There was a problem hiding this comment.
@adamziel Is change intentional as part of this PR?
There was a problem hiding this comment.
thanks! It got intertwined, a rebase will solve it – that's already merged into trunk
|
I merged trunk into this PR and fixed the single failing test. Let's see how the tests do in CI. |
|
we may need another merge but other than that this is good to go. Thank you for jumping in @brandonpayton! |
|
I don't think the test failures are related to this change, they're mostly timeouts. That, and the tests already passed before the merge. And their JSPI counterparts pass. Let's merge. Thank you for grooming this branch @brandonpayton ! |
Motivation for the change, related issues
Studio noted they can't easily used a local, unzipped WordPress directory:
This PR separates skipping the download from skipping the installation.
Implementation
This PR adds a new CLI option called
--wordpress-install-modewith the following supported values:Supersedes #2786
Testing instructions
Run
cc @bcotrim @brandonpayton